]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: page_pool: fix warning code
authorJohannes Berg <johannes.berg@intel.com>
Fri, 5 Jul 2024 11:42:06 +0000 (13:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 06:59:44 +0000 (08:59 +0200)
[ Upstream commit 946b6c48cca48591fb495508c5dbfade767173d0 ]

WARN_ON_ONCE("string") doesn't really do what appears to
be intended, so fix that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fixes: 90de47f020db ("page_pool: fragment API support for 32-bit arch with 64-bit DMA")
Link: https://patch.msgid.link/20240705134221.2f4de205caa1.I28496dc0f2ced580282d1fb892048017c4491e21@changeid
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/page_pool.c

index f4444b4e39e63a4fa0ad24f36db24123068a0152..3772eb63dcad13c66a5b4edfb314a30105181871 100644 (file)
@@ -445,7 +445,7 @@ static bool page_pool_dma_map(struct page_pool *pool, struct page *page)
        return true;
 
 unmap_failed:
-       WARN_ON_ONCE("unexpected DMA address, please report to netdev@");
+       WARN_ONCE(1, "unexpected DMA address, please report to netdev@");
        dma_unmap_page_attrs(pool->p.dev, dma,
                             PAGE_SIZE << pool->p.order, pool->p.dma_dir,
                             DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING);