]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-93910: [Enum] restore member.member restriction while keeping performance boost...
authorEthan Furman <ethan@stoneleaf.us>
Sun, 17 Jul 2022 01:13:57 +0000 (18:13 -0700)
committerGitHub <noreply@github.com>
Sun, 17 Jul 2022 01:13:57 +0000 (18:13 -0700)
Lib/enum.py
Lib/test/test_enum.py

index 652878ce1e1dfa2c47646321ecf90e52cfbe13cf..a4f1f09adae01c561f700395ab7bed7d90e6899c 100644 (file)
@@ -1101,6 +1101,14 @@ class Enum(metaclass=EnumType):
     def __init__(self, *args, **kwds):
         pass
 
+    def __getattribute__(self, name):
+        self_dict = super().__getattribute__('__dict__')
+        cls = super().__getattribute__('__class__')
+        value = super().__getattribute__(name)
+        if isinstance(value, cls) and name not in self_dict and name in self._member_names_:
+            raise AttributeError("<enum '%s'> member has no attribute %r" % (cls.__name__, name))
+        return super().__getattribute__(name)
+
     def _generate_next_value_(name, start, count, last_values):
         """
         Generate the next value when not given.
index aec18c79f7249e65a40da5fbdaaaae7007ca7d80..87d7c725014e3eacbeb71c45b2035f76cb056045 100644 (file)
@@ -2646,7 +2646,6 @@ class TestSpecial(unittest.TestCase):
         self.assertEqual(Private._Private__corporal, 'Radar')
         self.assertEqual(Private._Private__major_, 'Hoolihan')
 
-    @unittest.skip("Accessing all values retained for performance reasons, see GH-93910")
     def test_exception_for_member_from_member_access(self):
         with self.assertRaisesRegex(AttributeError, "<enum .Di.> member has no attribute .NO."):
             class Di(Enum):
@@ -2654,6 +2653,12 @@ class TestSpecial(unittest.TestCase):
                 NO = 0
             nope = Di.YES.NO
 
+    def test_no_exception_for_overridden_member_from_member_access(self):
+        class Di(Enum):
+            YES = 1
+            NO = 0
+        Di.YES.NO = Di.NO
+        nope = Di.YES.NO
 
     def test_dynamic_members_with_static_methods(self):
         #