- enhance only_on() to work with compound specs

- fix "temporary_tables" requirement

diff --git a/lib/sqlalchemy/testing/exclusions.py b/lib/sqlalchemy/testing/exclusions.py
index f94724608aeb1ce7454c1db8835ddfc81b6dfa0a..0aff43ae12d2827e0ff2dd7b623f8017995b3beb 100644 (file)
--- a/lib/sqlalchemy/testing/exclusions.py
+++ b/lib/sqlalchemy/testing/exclusions.py
@@ -425,7 +425,7 @@ def skip(db, reason=None):
 
 def only_on(dbs, reason=None):
     return only_if(
-        OrPredicate([SpecPredicate(db) for db in util.to_list(dbs)])
+        OrPredicate([Predicate.as_predicate(db) for db in util.to_list(dbs)])
     )
 
 

diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py
index da3e3128a0ed64d5066e88c6d55cafd7157def0a..5744431cba3dd69efe74973cb86687f25a066abb 100644 (file)
--- a/lib/sqlalchemy/testing/requirements.py
+++ b/lib/sqlalchemy/testing/requirements.py
@@ -322,6 +322,11 @@ class SuiteRequirements(Requirements):
         """target dialect supports listing of temporary table names"""
         return exclusions.closed()
 
+    @property
+    def temporary_tables(self):
+        """target database supports temporary tables"""
+        return exclusions.open()
+
     @property
     def temporary_views(self):
         """target database supports temporary views"""

diff --git a/test/requirements.py b/test/requirements.py
index d1b7913f0566d56317f1611e6fee0a55e571ba1d..22ac13fe89200a60ad7a80507c1bfee14ce539dc 100644 (file)
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -127,9 +127,15 @@ class DefaultRequirements(SuiteRequirements):
             )
 
     @property
-    def temporary_table(self):
-        """Target database must support CREATE TEMPORARY TABLE"""
-        return exclusions.open()
+    def temporary_tables(self):
+        """target database supports temporary tables"""
+        return skip_if(
+                    ["mssql"], "sql server has some other syntax?"
+                )
+
+    @property
+    def temp_table_reflection(self):
+        return self.temporary_tables
 
     @property
     def reflectable_autoincrement(self):

diff --git a/test/sql/test_metadata.py b/test/sql/test_metadata.py
index 0aa5d73052214cc1ff4026e78e5ca83efef2354a..52ecf88c54e669bbbca948bf12bb5a41f5035968 100644 (file)
--- a/test/sql/test_metadata.py
+++ b/test/sql/test_metadata.py
@@ -1160,9 +1160,10 @@ class InfoTest(fixtures.TestBase):
         t = Table('x', MetaData(), info={'foo': 'bar'})
         eq_(t.info, {'foo': 'bar'})
 
+
 class TableTest(fixtures.TestBase, AssertsCompiledSQL):
 
-    @testing.requires.temporary_table
+    @testing.requires.temporary_tables
     @testing.skip_if('mssql', 'different col format')
     def test_prefixes(self):
         from sqlalchemy import Table