]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
watch_queue: Use local kmap in post_one_notification()
authorDavidlohr Bueso <dave@stgolabs.net>
Tue, 18 Nov 2025 21:07:06 +0000 (13:07 -0800)
committerChristian Brauner <brauner@kernel.org>
Wed, 19 Nov 2025 11:17:28 +0000 (12:17 +0100)
Replace the now deprecated kmap_atomic() with kmap_local_page().

Optimize for the non-highmem cases and avoid disabling preemption and
pagefaults, the caller's context is atomic anyway, but that is irrelevant
to kmap. The memcpy itself does not require any such semantics and the
mapping would hold valid across context switches anyway. Further, highmem
is planned to to be removed[1].

[1] https://lore.kernel.org/all/4ff89b72-03ff-4447-9d21-dd6a5fe1550f@app.fastmail.com/

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://patch.msgid.link/20251118210706.1816303-1-dave@stgolabs.net
Signed-off-by: Christian Brauner <brauner@kernel.org>
kernel/watch_queue.c

index 7e45559521af952745230cb5ab7cbd1075bf240b..52f89f1137dacf4b145dc74659d3d9d0a6e2dcdd 100644 (file)
@@ -119,9 +119,9 @@ static bool post_one_notification(struct watch_queue *wqueue,
        offset = note % WATCH_QUEUE_NOTES_PER_PAGE * WATCH_QUEUE_NOTE_SIZE;
        get_page(page);
        len = n->info & WATCH_INFO_LENGTH;
-       p = kmap_atomic(page);
+       p = kmap_local_page(page);
        memcpy(p + offset, n, len);
-       kunmap_atomic(p);
+       kunmap_local(p);
 
        buf = pipe_buf(pipe, head);
        buf->page = page;