]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
With pg8000-1.9.13 passes engine/test_reconnect
authorTony Locke <tlocke@tlocke.org.uk>
Sat, 26 Jul 2014 15:19:09 +0000 (16:19 +0100)
committerTony Locke <tlocke@tlocke.org.uk>
Sat, 2 Aug 2014 14:29:36 +0000 (15:29 +0100)
The pg8000 dialect checks the text of the exception to determine if the
connection is closed. I'd (recklessly!) changed the text of the
exception in a recent version of the pg8000 driver adding capitalization
and a full stop. I've changed it back now so all works.

test/requirements.py

index e8705d145231b0fad6a23b025f00edeb0a68dfca..bf9b8f52632538585f827e58325e858acc333b32 100644 (file)
@@ -366,16 +366,6 @@ class DefaultRequirements(SuiteRequirements):
             no_support("postgresql+pg8000", "not supported and/or hangs")
             ])
 
-    @property
-    def graceful_disconnects(self):
-        """Target driver must raise a DBAPI-level exception, such as
-        InterfaceError, when the underlying connection has been closed
-        and the execute() method is called.
-        """
-        return fails_on(
-                    "postgresql+pg8000", "Driver crashes"
-                )
-
     @property
     def views(self):
         """Target database must support VIEWs."""