]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
pre-commit: check for whitespace errors in on all files under gdb
authorJan Vrany <jan.vrany@labware.com>
Fri, 7 Nov 2025 19:59:32 +0000 (19:59 +0000)
committerJan Vrany <jan.vrany@labware.com>
Fri, 7 Nov 2025 19:59:32 +0000 (19:59 +0000)
I got a review comment [1] because I forgot to run

    git diff --staged --check

to check commits before submitting. This commit adds a pre-commit hook
to do this automatically.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
[1]: https://inbox.sourceware.org/gdb-patches/c231d267-f541-4774-8005-6d433a9d6e96@simark.ca/

.pre-commit-config.yaml
gdb/contrib/check-whitespace-pre-commit.sh [new file with mode: 0755]

index 71c898f7c1e243e277bbfad644cfbcb6d8cf1d02..d26e55d33c5a9a7d9cb1d0e44b01dda23e719ab8 100644 (file)
@@ -97,6 +97,14 @@ repos:
       exclude: '.*/testsuite/.*'
       verbose: true
       stages: [pre-commit]
+    - id: check-whitespace
+      name: check-whitespace
+      language: script
+      entry: gdb/contrib/check-whitespace-pre-commit.sh
+      files: '^(gdb(support|server)?)/.*$'
+      pass_filenames: true
+      verbose: true
+      stages: [pre-commit]
   - repo: https://github.com/nmoroze/tclint
     rev: v0.6.1
     hooks:
diff --git a/gdb/contrib/check-whitespace-pre-commit.sh b/gdb/contrib/check-whitespace-pre-commit.sh
new file mode 100755 (executable)
index 0000000..db45dc2
--- /dev/null
@@ -0,0 +1,19 @@
+#!/bin/sh
+
+# Copyright (C) 2025 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+set -e
+
+git --no-pager diff --staged --check "$@"