]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-146245: Fix reference and buffer leaks via audit hook in socket module (GH-146248)
authorAN Long <aisk@users.noreply.github.com>
Sun, 22 Mar 2026 11:29:34 +0000 (19:29 +0800)
committerGitHub <noreply@github.com>
Sun, 22 Mar 2026 11:29:34 +0000 (13:29 +0200)
Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst [new file with mode: 0644]
Modules/socketmodule.c

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst
new file mode 100644 (file)
index 0000000..f52eaa0
--- /dev/null
@@ -0,0 +1 @@
+Fixed reference leaks in :mod:`socket` when audit hooks raise exceptions in :func:`socket.getaddrinfo` and :meth:`!socket.sendto`.
index d4df40c78e8a4fad44035f119216bb7f47708ac7..8215d51baf30e8ee7cb1def1834016899c22548b 100644 (file)
@@ -4808,6 +4808,7 @@ sock_sendto(PyObject *self, PyObject *args)
     }
 
     if (PySys_Audit("socket.sendto", "OO", s, addro) < 0) {
+        PyBuffer_Release(&pbuf);
         return NULL;
     }
 
@@ -6982,7 +6983,7 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
 
     if (PySys_Audit("socket.getaddrinfo", "OOiii",
                     hobj, pobj, family, socktype, protocol) < 0) {
-        return NULL;
+        goto err;
     }
 
     memset(&hints, 0, sizeof(hints));