]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
USB: serial: kobil_sct: log failure to update line settings
authorJohan Hovold <johan@kernel.org>
Wed, 1 Jul 2020 16:53:41 +0000 (18:53 +0200)
committerJohan Hovold <johan@kernel.org>
Thu, 2 Jul 2020 08:38:43 +0000 (10:38 +0200)
Log failure to update the line settings in set_termios().

This also avoids a W=1 (-Wunused-but-set-variable) warning.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/kobil_sct.c

index e9882ba209330472c0674526efd0eaf2f798974a..79ce0219fdde09d4a84e982369a8c282c401eafb 100644 (file)
@@ -526,6 +526,10 @@ static void kobil_set_termios(struct tty_struct *tty,
                  0,
                  KOBIL_TIMEOUT
                );
+       if (result) {
+               dev_err(&port->dev, "failed to update line settings: %d\n",
+                               result);
+       }
 }
 
 static int kobil_ioctl(struct tty_struct *tty,