]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Thu, 26 Jun 2025 17:24:10 +0000 (22:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:31 +0000 (16:22 +0200)
[ Upstream commit eb2cb7dab60f9be0b435ac4a674255429a36d72c ]

In the error paths after fb_info structure is successfully allocated,
the memory allocated in fb_deferred_io_init() for info->pagerefs is not
freed. Fix that by adding the cleanup function on the error path.

Fixes: c296d5f9957c ("staging: fbtft: core support")
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20250626172412.18355-1-abdun.nihaal@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/fbtft/fbtft-core.c

index d0c8d85f3db0f566965d586ea432c5ad14eb14bf..2c04fcff0e1c51b821e46db9311110d67d61451c 100644 (file)
@@ -745,6 +745,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
        return info;
 
 release_framebuf:
+       fb_deferred_io_cleanup(info);
        framebuffer_release(info);
 
 alloc_fail: