]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
http: don't crash when normalizing uri on low memory
authorVictor Julien <victor@inliniac.net>
Wed, 3 Dec 2014 15:08:19 +0000 (16:08 +0100)
committerVictor Julien <victor@inliniac.net>
Fri, 5 Dec 2014 09:01:17 +0000 (10:01 +0100)
src/app-layer-htp-libhtp.c

index fbe2df54f8461c4a5fc7cb20dc543694df93044f..69d862208d5fcbf536360ca5720701a04fedb238 100644 (file)
@@ -201,11 +201,13 @@ bstr *SCHTPGenerateNormalizedUri(htp_tx_t *tx, htp_uri_t *uri, int uri_include_a
 
     if (uri->query != NULL) {
         bstr *query = bstr_dup(uri->query);
-        uint64_t flags = 0;
-        htp_urldecode_inplace(tx->cfg, HTP_DECODER_URLENCODED, query, &flags);
-        bstr_add_c_noex(r, "?");
-        bstr_add_noex(r, query);
-        bstr_free(query);
+        if (query) {
+            uint64_t flags = 0;
+            htp_urldecode_inplace(tx->cfg, HTP_DECODER_URLENCODED, query, &flags);
+            bstr_add_c_noex(r, "?");
+            bstr_add_noex(r, query);
+            bstr_free(query);
+        }
     }
 
     if (uri->fragment != NULL) {