]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: client: fix potential UAF in cifs_stats_proc_show()
authorPaulo Alcantara <pc@manguebit.com>
Tue, 2 Apr 2024 19:33:56 +0000 (16:33 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:36:05 +0000 (16:36 +0200)
commit 0865ffefea197b437ba78b5dd8d8e256253efd65 upstream.

Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/client/cifs_debug.c

index b4d2ee2d5e6c7809c7c519082f610a7d1e4fce28..6c85edb8635d01daaccb2fb2cb8c2fda2f1a1d8c 100644 (file)
@@ -736,6 +736,8 @@ static int cifs_stats_proc_show(struct seq_file *m, void *v)
                        }
 #endif /* STATS2 */
                list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
+                       if (cifs_ses_exiting(ses))
+                               continue;
                        list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
                                i++;
                                seq_printf(m, "\n%d) %s", i, tcon->tree_name);