]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-index: Remove obsolete FIXMEs about upcoming sync lock removal
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Mon, 12 Feb 2024 08:30:34 +0000 (10:30 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Mon, 20 Oct 2025 05:53:35 +0000 (05:53 +0000)
That is never going to happen.

src/lib-index/mail-index-sync-update.c
src/lib-index/mail-transaction-log-append.c

index 622e6ab747190acbbf8a528831e8db18a3ee9533..16ea5aa088b598a25ebbf50cdf025fe7e817f001 100644 (file)
@@ -1002,11 +1002,6 @@ int mail_index_sync_map(struct mail_index_map **_map,
        }
        map = NULL;
 
-       /* FIXME: when transaction sync lock is removed, we'll need to handle
-          the case when a transaction is committed while mailbox is being
-          synced ([synced transactions][new transaction][ext transaction]).
-          this means int_offset contains [synced] and ext_offset contains
-          all */
        while ((ret = mail_transaction_log_view_next(view->log_view, &thdr,
                                                     &tdata)) > 0) {
                mail_transaction_log_view_get_prev_pos(view->log_view,
index 7ed2984deb2daf0dd1eda7fd450d80edae90e00d..429296bcc035aaa591af68d94941523d4f8f06f9 100644 (file)
@@ -143,10 +143,6 @@ log_append_sync_offset_if_needed(struct mail_transaction_log_append_ctx *ctx)
                        return;
                }
 
-               /* FIXME: when we remove exclusive log locking, we
-                  can't rely on this. then write non-changed offset + check
-                  real offset + rewrite the new offset if other transactions
-                  weren't written in the middle */
                offset = file->max_tail_offset + ctx->output->used +
                        sizeof(*hdr) + sizeof(*u) + sizeof(offset);
                ctx->sync_includes_this = TRUE;