]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Bluetooth: ISO: Fix another instance of dst_type handling
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Tue, 7 Oct 2025 17:29:15 +0000 (13:29 -0400)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 24 Oct 2025 14:30:50 +0000 (10:30 -0400)
Socket dst_type cannot be directly assigned to hci_conn->type since
there domain is different which may lead to the wrong address type being
used.

Fixes: 6a5ad251b7cd ("Bluetooth: ISO: Fix possible circular locking dependency")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/iso.c

index 954e1916506b1b14e83d7c028258450be5e469a2..3d98cb6291da67a9e234fbc705aff457bc9bf424 100644 (file)
@@ -2046,7 +2046,13 @@ static void iso_conn_ready(struct iso_conn *conn)
                }
 
                bacpy(&iso_pi(sk)->dst, &hcon->dst);
-               iso_pi(sk)->dst_type = hcon->dst_type;
+
+               /* Convert from HCI to three-value type */
+               if (hcon->dst_type == ADDR_LE_DEV_PUBLIC)
+                       iso_pi(sk)->dst_type = BDADDR_LE_PUBLIC;
+               else
+                       iso_pi(sk)->dst_type = BDADDR_LE_RANDOM;
+
                iso_pi(sk)->sync_handle = iso_pi(parent)->sync_handle;
                memcpy(iso_pi(sk)->base, iso_pi(parent)->base, iso_pi(parent)->base_len);
                iso_pi(sk)->base_len = iso_pi(parent)->base_len;