]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver.c: do not redefine 'event' in qemuDomainDefineXMLFlags()
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Fri, 13 Nov 2020 17:46:49 +0000 (14:46 -0300)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Fri, 13 Nov 2020 19:53:22 +0000 (16:53 -0300)
A bad merge while rebasing 74b2834333a caused the @event variable
to be defined twice, inside the 'cleanup' label, causing coverity
errors.

This code was originally moved outside of the label by commit
773c7c43611a. Delete the unintended code in the 'cleanup'
label.

Fixes: 74b2834333ab3bf500f870e0a6d4e8309379d96a
Reported-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_driver.c

index 78ccf96df5dc8983bc9c05f486f1123bf96fd340..ac38edf0094a241ac5b1e912e685847b451ca074 100644 (file)
@@ -6748,15 +6748,6 @@ qemuDomainDefineXMLFlags(virConnectPtr conn,
         }
     }
 
-    event = virDomainEventLifecycleNewFromObj(vm,
-                                     VIR_DOMAIN_EVENT_DEFINED,
-                                     !oldDef ?
-                                     VIR_DOMAIN_EVENT_DEFINED_ADDED :
-                                     VIR_DOMAIN_EVENT_DEFINED_UPDATED);
-
-    VIR_INFO("Creating domain '%s'", vm->def->name);
-    dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id);
-
     virDomainObjEndAPI(&vm);
     virObjectEventStateQueue(driver->domainEventState, event);
     return dom;