]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
testprogs: Fix shellcheck errors in test_wintest.sh
authorAndreas Schneider <asn@samba.org>
Mon, 13 Jun 2022 14:08:40 +0000 (16:08 +0200)
committerPavel Filipensky <pfilipensky@samba.org>
Mon, 22 Aug 2022 20:35:36 +0000 (20:35 +0000)
testprogs/blackbox/test_wintest.sh:15:97: error: Double quote array
expansions to avoid re-splitting elements. [SC2068]

testprogs/blackbox/test_wintest.sh:40:31: error: Double quote array
expansions to avoid re-splitting elements. [SC2068]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
testprogs/blackbox/test_wintest.sh

index 23f7385cfb7d40852307bd43ed414dcfdb8138d0..1015a1ef299627eee5e348462cf07bb437bdf1ba 100755 (executable)
@@ -12,7 +12,7 @@ testwithconf()
                . $WINTEST_STARTUP
        fi
 
-       testit "smbtorture" $smbtorture //$SERVER/$SHARE RAW-OPEN -W "$DOMAIN" -U"$USERNAME%$PASSWORD" $@ || failed=$(expr $failed + 1)
+       testit "smbtorture" $smbtorture //$SERVER/$SHARE RAW-OPEN -W "$DOMAIN" -U"$USERNAME%$PASSWORD" "$@" || failed=$(expr $failed + 1)
 
        if [ -n "$WINTEST_SHUTDOWN" ]; then
                . $WINTEST_SHUTDOWN
@@ -37,7 +37,7 @@ smbtorture=$samba4bindir/smbtorture
 . $(dirname $0)/subunit.sh
 
 for wintest_conf in $WINTEST_CONF_DIR/*.conf; do
-       testwithconf "$wintest_conf" $@
+       testwithconf "$wintest_conf" "$@"
 done
 
 exit $failed