]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: sn-f-ospi: fix incorrect return code for invalid num-cs
authorFelix Gu <ustc.gu@gmail.com>
Sat, 11 Apr 2026 11:49:38 +0000 (19:49 +0800)
committerMark Brown <broonie@kernel.org>
Sat, 11 Apr 2026 11:58:16 +0000 (12:58 +0100)
Returning -ENOMEM for an invalid num-cs value is semantically wrong. Use
-EINVAL instead.

Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260411-ispi-v1-1-af384e81c4c8@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sn-f-ospi.c

index 3c61c799723bba9cda5e92e6a65797fbf4ba2325..b459d51cb3a87e5c3172594fdb4294cd5934bea5 100644 (file)
@@ -625,7 +625,7 @@ static int f_ospi_probe(struct platform_device *pdev)
        of_property_read_u32(dev->of_node, "num-cs", &num_cs);
        if (num_cs > OSPI_NUM_CS) {
                dev_err(dev, "num-cs too large: %d\n", num_cs);
-               return -ENOMEM;
+               return -EINVAL;
        }
        ctlr->num_chipselect = num_cs;