]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda/realtek - ALC285 reduce pop noise from Headphone port
authorKailang Yang <kailang@realtek.com>
Fri, 23 Feb 2024 06:54:34 +0000 (14:54 +0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:21:13 +0000 (18:21 -0400)
[ Upstream commit b34bf65838f7c6e785f62681605a538b73c2808c ]

It had pop noise from Headphone port when system reboot state.
If NID 58h Index 0x0 to fill default value, it will reduce pop noise.

Signed-off-by: Kailang Yang <kailang@realtek.com>
Link: https://lore.kernel.org/r/7493e207919a4fb3a0599324fd010e3e@realtek.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/patch_realtek.c

index a6e6ed1355abf3abcd858b7fe9dbe7b1089fb03f..3a86f0fd782787a990d6eb2a4ca689b6c1f40d1b 100644 (file)
@@ -3675,6 +3675,7 @@ static void alc285_hp_init(struct hda_codec *codec)
        int i, val;
        int coef38, coef0d, coef36;
 
+       alc_write_coefex_idx(codec, 0x58, 0x00, 0x1888); /* write default value */
        alc_update_coef_idx(codec, 0x4a, 1<<15, 1<<15); /* Reset HP JD */
        coef38 = alc_read_coef_idx(codec, 0x38); /* Amp control */
        coef0d = alc_read_coef_idx(codec, 0x0d); /* Digital Misc control */