]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
kcc: use py3 compatible sort in rarely visited branch
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 2 Dec 2020 00:47:14 +0000 (13:47 +1300)
committerJeremy Allison <jra@samba.org>
Wed, 17 Mar 2021 17:10:32 +0000 (17:10 +0000)
This won't have worked for some time, but nobody has complained,
because nobody uses DS_NTDSSETTINGS_OPT_IS_RAND_BH_SELECTION_DISABLED

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
python/samba/kcc/__init__.py

index 73cdc9f1ef0570f926364e0b5de13d7f748a363b..c87cc14fcff9a9bf9bd5fe3bab8ef05cc24b9283 100644 (file)
@@ -21,7 +21,7 @@
 
 import random
 import uuid
-
+from functools import cmp_to_key
 import itertools
 from samba import unix2nttime, nttime2unix
 from samba import ldb, dsdb, drs_utils
@@ -1285,7 +1285,7 @@ class KCC(object):
         # ELSE
         #    SORT bhs in a random order
         if site.is_random_bridgehead_disabled():
-            bhs.sort(sort_dsa_by_gc_and_guid)
+            bhs.sort(key=cmp_to_key(sort_dsa_by_gc_and_guid))
         else:
             random.shuffle(bhs)
         debug.DEBUG_YELLOW(bhs)