]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
dereference after NULL. CID #142093
authorAlan T. DeKok <aland@freeradius.org>
Fri, 10 Nov 2017 20:55:22 +0000 (15:55 -0500)
committerAlan T. DeKok <aland@freeradius.org>
Fri, 10 Nov 2017 20:55:22 +0000 (15:55 -0500)
src/main/xlat_eval.c

index fe0e13b123465e58a48fe33ff15944ba03b3b57e..518473185a2ea6c3251fea92972c4a3075718f33 100644 (file)
@@ -476,8 +476,8 @@ static rlm_rcode_t xlat_eval_pair(TALLOC_CTX *ctx, fr_cursor_t *out, REQUEST *re
                 */
                vp = fr_cursor_current(&cursor);                        /* NULLness checked above */
                value = fr_value_box_alloc(ctx, vp->data.type, vp->da, vp->data.tainted);
-               fr_value_box_copy_shallow(value, value, &vp->data);     /* Also dups taint */
                if (!value) goto oom;
+               fr_value_box_copy_shallow(value, value, &vp->data);     /* Also dups taint */
                fr_cursor_append(out, value);
                return RLM_MODULE_UPDATED;
        }