]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: fix for the isoc transfer EP_BUSY flag
authorKonrad Leszczynski <konrad.leszczynski@intel.com>
Mon, 8 Feb 2016 15:13:12 +0000 (16:13 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 Nov 2016 01:16:41 +0000 (01:16 +0000)
commit 9cad39fe4e4a4fe95d8ea5a7b0692b0a6e89e38b upstream.

commit f3af36511e60 ("usb: dwc3: gadget: always
enable IOC on bulk/interrupt transfers") ended up
regressing Isochronous endpoints by clearing
DWC3_EP_BUSY flag too early, which resulted in
choppy audio playback over USB.

Fix that by partially reverting original commit and
making sure that we check for isochronous endpoints.

Fixes: f3af36511e60 ("usb: dwc3: gadget: always enable IOC
on bulk/interrupt transfers")
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/dwc3/gadget.c

index 4a279bb9092ac3a821096a086c8b8d864fc2ef81..a2610985dd7dc3bfe0140471366f943d70390138 100644 (file)
@@ -2016,6 +2016,10 @@ static int dwc3_cleanup_done_reqs(struct dwc3 *dwc, struct dwc3_ep *dep,
                return 1;
        }
 
+       if (usb_endpoint_xfer_isoc(dep->endpoint.desc))
+               if ((event->status & DEPEVT_STATUS_IOC) &&
+                               (trb->ctrl & DWC3_TRB_CTRL_IOC))
+                       return 0;
        return 1;
 }