]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
selftest/container: fix IMAGE_FEATURES assignment
authorRoss Burton <ross.burton@arm.com>
Tue, 5 Nov 2024 19:48:54 +0000 (19:48 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 6 Nov 2024 10:11:06 +0000 (10:11 +0000)
Assigning IMAGE_FEATURES="" in local.conf doesn't actually do anything
useful, as bitbake.conf has IMAGE_FEATURES += EXTRA_IMAGE_FEATURES after
the include of local.conf.

In this test case, this results in IMAGE_FEATURES still using
EXTRA_IMAGE_FEATURES, so the image contains the files installed by the
post-install-logging feature.

As the intention here is that container-test-image is as minimal as
possible, move the IMAGE_FEATURES assignment into the image itself so
it actually works, and update the expected file list to remove the
post-install-logging files.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta-selftest/recipes-test/container-image/container-test-image.bb
meta/lib/oeqa/selftest/cases/containerimage.py

index d5f939c6e989d2aca025db7e5844293a5987f598..26b6409d1d61a65de4489ee63cc08c55e449290e 100644 (file)
@@ -4,5 +4,6 @@ LICENSE = "MIT"
 
 IMAGE_FSTYPES = "container"
 IMAGE_LINGUAS = ""
+IMAGE_FEATURES = ""
 
 inherit core-image
index 23c0a1408a3fb67a4444cb1cf987bae299af4854..d1ac305a845624f395f9e53770b39131a7fa7dd0 100644 (file)
@@ -42,7 +42,6 @@ class ContainerImageTests(OESelftestTestCase):
         self.write_config("""PREFERRED_PROVIDER_virtual/kernel = "linux-dummy"
 IMAGE_FSTYPES = "container"
 PACKAGE_CLASSES = "package_ipk"
-IMAGE_FEATURES = ""
 IMAGE_BUILDINFO_FILE = ""
 INIT_MANAGER = "sysvinit"
 IMAGE_INSTALL:remove = "ssh-pregen-hostkeys"
@@ -55,8 +54,6 @@ IMAGE_INSTALL:remove = "ssh-pregen-hostkeys"
         expected_files = [
                     './',
                     '.{bindir}/theapp',
-                    '.{sysconfdir}/default/',
-                    '.{sysconfdir}/default/postinst',
                     '.{sysconfdir}/ld.so.cache',
                     '.{sysconfdir}/timestamp',
                     '.{sysconfdir}/version',