]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: accel: adxl345: simplify tap suppress bit
authorLothar Rubusch <l.rubusch@gmail.com>
Sun, 27 Jul 2025 21:00:08 +0000 (21:00 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 16 Aug 2025 10:57:07 +0000 (11:57 +0100)
Simplify setting the tap suppress bit by applying regmap_assign_bit(). As a
result, the defines can be reorganized for better clarity.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Link: https://patch.msgid.link/20250727210014.27766-2-l.rubusch@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/adxl345_core.c

index b7dfd0007aa068daefc8cd6ec627655303c6d198..e293fc91797233682c393dc89bfba8f942b86a48 100644 (file)
 #define ADXL345_INT2                   1
 
 #define ADXL345_REG_TAP_AXIS_MSK       GENMASK(2, 0)
-#define ADXL345_REG_TAP_SUPPRESS_MSK   BIT(3)
-#define ADXL345_REG_TAP_SUPPRESS       BIT(3)
-
 #define ADXL345_TAP_Z_EN               BIT(0)
 #define ADXL345_TAP_Y_EN               BIT(1)
 #define ADXL345_TAP_X_EN               BIT(2)
+#define ADXL345_REG_TAP_SUPPRESS       BIT(3)
 
 /* single/double tap */
 enum adxl345_tap_type {
@@ -368,9 +366,8 @@ static int adxl345_set_doubletap_en(struct adxl345_state *st, bool en)
         * Generally suppress detection of spikes during the latency period as
         * double taps here, this is fully optional for double tap detection
         */
-       ret = regmap_update_bits(st->regmap, ADXL345_REG_TAP_AXIS,
-                                ADXL345_REG_TAP_SUPPRESS_MSK,
-                                en ? ADXL345_REG_TAP_SUPPRESS : 0x00);
+       ret = regmap_assign_bits(st->regmap, ADXL345_REG_TAP_AXIS,
+                                ADXL345_REG_TAP_SUPPRESS, en);
        if (ret)
                return ret;