]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 10 Oct 2025 17:31:41 +0000 (10:31 -0700)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 16 Oct 2025 15:57:50 +0000 (17:57 +0200)
In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
the RK3328 variant. This change updates it to the RK3228-specific mask
RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
I2C pin configuration for RK3228.

Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK

Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20251010173143.72733-1-alok.a.tiwari@oracle.com
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

index 7b613997bb501bb2ee88c386b5ee1cbbfcae1c9d..727cdf768161a55aa12a9aeba172a8f462da01a0 100644 (file)
@@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
 
        regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
                     FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
-                    FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
+                    FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
 }
 
 static enum drm_connector_status