I'm baaaaaaaaaack. :)

 Post a warning to the console that things might possibly be misconfigured when queue member's states are still 'Not in Use' when we're about to bridge them with a caller from queue. Also, put some documentation quoted from oej's queues.txt efforts started in /trunk today.
 This commit puts #7433 into feedback state for 1.4, and pending no further negative feedback, it will finally be closed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53129 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/UPGRADE.txt b/UPGRADE.txt
index 2f90be4296349bdfa7ad078e11bd3198232aaaf4..46bf90d06f7a92e544faa65cd12a23f4837a8d75 100644 (file)
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -163,6 +163,23 @@ Applications:
   option, it will default to "no" to keep backward compatability with the old 
   behavior.
 
+* Queues depend on the channel driver reporting the proper state
+  for each member of the queue. To get proper signalling on
+  queue members that use the SIP channel driver, you need to
+  enable a call limit (could be set to a high value so it
+  is not put into action) and also make sure that both inbound
+  and outbound calls are accounted for.
+
+  Example:
+
+       [general]
+       limitonpeer = yes
+
+       [peername]
+       type=friend
+       call-limit=10
+
+
 * The app_queue application now has the ability to use MixMonitor to 
   record conversations queue members are having with queue callers. Please
   see configs/queues.conf.sample for more information on this option.

diff --git a/apps/app_queue.c b/apps/app_queue.c
index 98223946ffda3ed9540b0d30f12f686ddc2c247f..22da470cfa61c69daecaeee71c1b1dc2ddb1ac18 100644 (file)
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -2637,6 +2637,10 @@ static int try_calling(struct queue_ent *qe, const char *options, char *announce
                ast_copy_string(oldexten, qe->chan->exten, sizeof(oldexten));
                time(&callstart);
 
+               if (member->status == AST_DEVICE_NOT_INUSE)
+                       ast_log(LOG_WARNING, "The device state of this queue member, %s, is still 'Not in Use' when it probably should not be! Please check UPGRADE.txt for correct configuration settings.\n", member->membername);
+                       
+
                bridge = ast_bridge_call(qe->chan,peer, &bridge_config);
 
                if (strcasecmp(oldcontext, qe->chan->context) || strcasecmp(oldexten, qe->chan->exten)) {