]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-netlink: make message_seal() accept already sealed messages
authorYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 7 Jul 2021 01:05:08 +0000 (10:05 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Sun, 29 Aug 2021 08:14:07 +0000 (17:14 +0900)
The function can be idempotent. It is not necessary to refuse already
sealed messages.

src/libsystemd/sd-netlink/netlink-message.c

index 922700c6340b9640e64e416da4ecec44dde66e53..075d0218844fca2dbdcff9f8329f95c23dd07a44 100644 (file)
@@ -1307,8 +1307,7 @@ int sd_netlink_message_rewind(sd_netlink_message *m, sd_netlink *genl) {
         assert_return(genl || m->protocol != NETLINK_GENERIC, -EINVAL);
 
         /* don't allow appending to message once parsed */
-        if (!m->sealed)
-                message_seal(m);
+        message_seal(m);
 
         for (unsigned i = 1; i <= m->n_containers; i++)
                 m->containers[i].attributes = mfree(m->containers[i].attributes);
@@ -1351,7 +1350,6 @@ int sd_netlink_message_rewind(sd_netlink_message *m, sd_netlink *genl) {
 
 void message_seal(sd_netlink_message *m) {
         assert(m);
-        assert(!m->sealed);
 
         m->sealed = true;
 }