]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: dummy_can: dummy_can_init(): fix packet statistics
authorOliver Hartkopp <socketcan@hartkopp.net>
Mon, 26 Jan 2026 10:45:40 +0000 (11:45 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 2 Mar 2026 09:24:41 +0000 (10:24 +0100)
The former implementation was only counting the tx_packets value but not
the tx_bytes as the skb was dropped on driver layer.

Enable CAN echo support (IFF_ECHO) in dummy_can_init(), which activates the
code for setting and retrieving the echo SKB and counts the tx_bytes
correctly.

Fixes: 816cf430e84b ("can: add dummy_can driver")
Cc: Vincent Mailhol <mailhol@kernel.org>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Link: https://patch.msgid.link/20260126104540.21024-1-socketcan@hartkopp.net
[mkl: make commit message imperative]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dummy_can.c

index 41953655e3d3c9187d6574710e6aa90fc01c92a7..cd23de488edce22e52d092189d3e60690d8bdb3a 100644 (file)
@@ -241,6 +241,7 @@ static int __init dummy_can_init(void)
 
        dev->netdev_ops = &dummy_can_netdev_ops;
        dev->ethtool_ops = &dummy_can_ethtool_ops;
+       dev->flags |= IFF_ECHO; /* enable echo handling */
        priv = netdev_priv(dev);
        priv->can.bittiming_const = &dummy_can_bittiming_const;
        priv->can.bitrate_max = 20 * MEGA /* BPS */;