]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ionic: fix potential irq name truncation
authorShannon Nelson <shannon.nelson@amd.com>
Wed, 29 May 2024 00:02:53 +0000 (17:02 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:06:41 +0000 (11:06 +0200)
[ Upstream commit 3eb76e71b16e8ba5277bf97617aef51f5e64dbe4 ]

Address a warning about potential string truncation based on the
string buffer sizes.  We can add some hints to the string format
specifier to set limits on the resulting possible string to
squelch the complaints.

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20240529000259.25775-2-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 324ef6990e9a76461403d1ea707fb40bdb6f67bd..f0c48f20d086df615a80e6cb90301b14280fd86b 100644 (file)
@@ -210,7 +210,7 @@ static int ionic_request_irq(struct ionic_lif *lif, struct ionic_qcq *qcq)
                name = dev_name(dev);
 
        snprintf(intr->name, sizeof(intr->name),
-                "%s-%s-%s", IONIC_DRV_NAME, name, q->name);
+                "%.5s-%.16s-%.8s", IONIC_DRV_NAME, name, q->name);
 
        return devm_request_irq(dev, intr->vector, ionic_isr,
                                0, intr->name, &qcq->napi);