INSIST that active quota is 0 in destroy_adbentry()

This should catch ADB quota management errors in the resolver.

diff --git a/lib/dns/adb.c b/lib/dns/adb.c
index d096c6185de32bf579275f1f033182b3b3c7aa7e..523f5709d410357c1e039efc072612506825e8ca 100644 (file)
--- a/lib/dns/adb.c
+++ b/lib/dns/adb.c
@@ -1173,11 +1173,15 @@ destroy_adbentry(dns_adbentry_t *entry) {
 
        dns_adblameinfo_t *li = NULL;
        dns_adb_t *adb = entry->adb;
+       uint_fast32_t active;
 
        entry->magic = 0;
 
        INSIST(ISC_LIST_EMPTY(entry->nhs));
 
+       active = atomic_load_acquire(&entry->active);
+       INSIST(active == 0);
+
        if (entry->cookie != NULL) {
                isc_mem_put(adb->mctx, entry->cookie, entry->cookielen);
        }