]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 30 Oct 2018 15:35:02 +0000 (08:35 -0700)
committerGitHub <noreply@github.com>
Tue, 30 Oct 2018 15:35:02 +0000 (08:35 -0700)
The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af770870937271865b5e2b05a2cfe40b024b6)

Co-authored-by: Daniel Lovell <lovell.daniel92@gmail.com>
Doc/library/tkinter.rst

index 4af4b7356e1ce3bcb3af13aa03f8a3a8f9a8cee0..60cf892e0888b718eceeb9e96f4801395fb3bf70 100644 (file)
@@ -205,6 +205,7 @@ A Simple Hello World Program
     class Application(tk.Frame):
         def __init__(self, master=None):
             super().__init__(master)
+            self.master = master
             self.pack()
             self.create_widgets()
 
@@ -215,7 +216,7 @@ A Simple Hello World Program
             self.hi_there.pack(side="top")
 
             self.quit = tk.Button(self, text="QUIT", fg="red",
-                                  command=root.destroy)
+                                  command=self.master.destroy)
             self.quit.pack(side="bottom")
 
         def say_hi(self):