]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/bridge: cdns: Fix PM reference leak in cdns_dsi_transfer()
authorZou Wei <zou_wei@huawei.com>
Mon, 24 May 2021 07:21:02 +0000 (15:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 06:53:09 +0000 (08:53 +0200)
[ Upstream commit 33f90f27e1c5ccd648d3e78a1c28be9ee8791cf1 ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1621840862-106024-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/cdns-dsi.c

index 6166dca6be813ebc8ca3629d94108f4e76168cb7..0cb9dd6986ec318376f79dd2ca6565907992d816 100644 (file)
@@ -1026,7 +1026,7 @@ static ssize_t cdns_dsi_transfer(struct mipi_dsi_host *host,
        struct mipi_dsi_packet packet;
        int ret, i, tx_len, rx_len;
 
-       ret = pm_runtime_get_sync(host->dev);
+       ret = pm_runtime_resume_and_get(host->dev);
        if (ret < 0)
                return ret;