]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2676] Note why Cmdctl is not converted.
authorMichal 'vorner' Vaner <michal.vaner@nic.cz>
Mon, 18 Feb 2013 10:23:08 +0000 (11:23 +0100)
committerMichal 'vorner' Vaner <michal.vaner@nic.cz>
Mon, 18 Feb 2013 10:30:56 +0000 (11:30 +0100)
Similar to previous commit, there's a hack in cmdctl that doesn't allow
it now.

src/bin/cmdctl/cmdctl.py.in

index 15a41ecc6e90314138547df53ea20889e8e7ec48..646801695e4d6bdc2edeea3d9879a4707e85e1f2 100755 (executable)
@@ -429,8 +429,13 @@ class CommandControl():
             # Process the command sent to cmdctl directly.
             answer = self.command_handler(command_name, params)
         else:
+            # FIXME: Due to the fact that we use a separate session
+            # from the module one (due to threads and blocking), and
+            # because the plain cc session does not have the high-level
+            # rpc-call method, we use the low-level way and create the
+            # command ourself.
             msg = ccsession.create_command(command_name, params)
-            seq = self._cc.group_sendmsg(msg, module_name)
+            seq = self._cc.group_sendmsg(msg, module_name, want_answer=True)
             logger.debug(DBG_CMDCTL_MESSAGING, CMDCTL_COMMAND_SENT,
                          command_name, module_name)
             #TODO, it may be blocked, msqg need to add a new interface waiting in timeout.