]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Revert "bpo-44645: Check for interrupts on any potentially backwards edge. (GH-27167...
authorPablo Galindo Salgado <Pablogsal@gmail.com>
Fri, 16 Jul 2021 17:05:47 +0000 (18:05 +0100)
committerGitHub <noreply@github.com>
Fri, 16 Jul 2021 17:05:47 +0000 (19:05 +0200)
This reverts commit 000e70ad5246732fcbd27cf59268185cbd5ad734.

Lib/test/test_threading.py
Python/ceval.c

index 3b5bc42357e586c688d064cf16226eef6a8afe5b..f648a8b2bc52f514080b666842d2bba7eddac3f8 100644 (file)
@@ -1604,31 +1604,6 @@ class InterruptMainTests(unittest.TestCase):
         self.assertRaises(ValueError, _thread.interrupt_main, signal.NSIG)
         self.assertRaises(ValueError, _thread.interrupt_main, 1000000)
 
-    @threading_helper.reap_threads
-    def test_can_interrupt_tight_loops(self):
-        cont = True
-        started = False
-        iterations = 100_000_000
-
-        def worker():
-            nonlocal iterations
-            nonlocal started
-            started = True
-            while cont:
-                if iterations:
-                    iterations -= 1
-                else:
-                    return
-                pass
-
-        t = threading.Thread(target=worker)
-        t.start()
-        while not started:
-            pass
-        cont = False
-        t.join()
-        self.assertNotEqual(iterations, 0)
-
 
 class AtexitTests(unittest.TestCase):
 
index 90112aa3f9476e409a9c14c88d6e5db9ae231b41..a6eb83a4909d72f928cc79635ed96bc277ba46b3 100644 (file)
@@ -3638,17 +3638,14 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, PyFrameObject *f, int throwflag)
             if (Py_IsFalse(cond)) {
                 Py_DECREF(cond);
                 JUMPTO(oparg);
-                CHECK_EVAL_BREAKER();
                 DISPATCH();
             }
             err = PyObject_IsTrue(cond);
             Py_DECREF(cond);
             if (err > 0)
                 ;
-            else if (err == 0) {
+            else if (err == 0)
                 JUMPTO(oparg);
-                CHECK_EVAL_BREAKER();
-            }
             else
                 goto error;
             DISPATCH();
@@ -3665,14 +3662,12 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, PyFrameObject *f, int throwflag)
             if (Py_IsTrue(cond)) {
                 Py_DECREF(cond);
                 JUMPTO(oparg);
-                CHECK_EVAL_BREAKER();
                 DISPATCH();
             }
             err = PyObject_IsTrue(cond);
             Py_DECREF(cond);
             if (err > 0) {
                 JUMPTO(oparg);
-                CHECK_EVAL_BREAKER();
             }
             else if (err == 0)
                 ;