]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
hs-v3: Fix memory leak in test_hs_control_store_permanent_creds()
authorGeorge Kadianakis <desnacked@riseup.net>
Wed, 4 Dec 2019 11:40:03 +0000 (13:40 +0200)
committerDavid Goulet <dgoulet@torproject.org>
Tue, 10 Dec 2019 14:42:05 +0000 (09:42 -0500)
src/test/test_hs_control.c

index d064f203a677c98d0a3e78ba8e3f8788fbb7e25e..33ea9ada7f30d1f91c00c26de1073a7743e32918 100644 (file)
@@ -525,6 +525,7 @@ test_hs_control_store_permanent_creds(void *arg)
   { /* Setup ClientOnionAuthDir */
     int ret;
     char *perm_creds_dir = tor_strdup(get_fname("permanent_credentials"));
+    get_options_mutable()->ClientOnionAuthDir = perm_creds_dir;
 
     #ifdef _WIN32
       ret = mkdir(perm_creds_dir);
@@ -532,8 +533,6 @@ test_hs_control_store_permanent_creds(void *arg)
       ret = mkdir(perm_creds_dir, 0700);
     #endif
     tt_int_op(ret, OP_EQ, 0);
-
-    get_options_mutable()->ClientOnionAuthDir = perm_creds_dir;
   }
 
   tor_free(args);
@@ -622,6 +621,7 @@ test_hs_control_store_permanent_creds(void *arg)
   tt_uint_op(digest256map_size(client_auths), OP_EQ, 0);
 
  done:
+  tor_free(get_options_mutable()->ClientOnionAuthDir);
   tor_free(args);
   tor_free(cp1);
   buf_free(TO_CONN(&conn)->outbuf);