Add a missing ntohl to tell_controller_about_resolve_result

Fix for bug 5723; bugfix on 0.2.3.1-alpha (commit 22f723e4)

diff --git a/changes/bug5723 b/changes/bug5723
new file mode 100644 (file)
index 0000000..7f0dcb8
--- /dev/null
+++ b/changes/bug5723
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Format IPv4 addresses correctly in ADDRMAP events. (Previously,
+      we had reversed them when the answer was cached.) Fixes bug
+      5723; bugfix on 0.2.3.1-alpha.

diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index 03558e557c908936ff05e2b9174c320c6cd3a234..5ef56a63b025cc13c26849920885caf6abf9402b 100644 (file)
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -2745,7 +2745,7 @@ tell_controller_about_resolved_result(entry_connection_t *conn,
                    answer_type == RESOLVED_TYPE_HOSTNAME)) {
     return; /* we already told the controller. */
   } else if (answer_type == RESOLVED_TYPE_IPV4 && answer_len >= 4) {
-    char *cp = tor_dup_ip(get_uint32(answer));
+    char *cp = tor_dup_ip(ntohl(get_uint32(answer)));
     control_event_address_mapped(conn->socks_request->address,
                                  cp, expires, NULL);
     tor_free(cp);