]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:rpc_server: Initialize array struct security_ace ace[]
authorPavel Filipenský <pfilipensky@samba.org>
Wed, 3 Jul 2024 15:55:31 +0000 (17:55 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 5 Jul 2024 08:53:07 +0000 (08:53 +0000)
Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/smb2/lease.c:567: var_decl: Declaring variable "h" without initializer.
samba-4.20.0rc2/source4/torture/smb2/lease.c:642: uninit_use_in_call: Using uninitialized value "h" when calling "smb2_util_close".
  640|
  641|    done:
  642|->         smb2_util_close(tree, h);
  643|           smb2_util_close(tree, h2);
  644|

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jul  5 08:53:08 UTC 2024 on atb-devel-224

source3/rpc_server/lsa/srv_lsa_nt.c

index 8bd2914538b2796bb638482c33546fb96a196b40..bf8ad241a5b1a2f6048726f7c5db801bc7abd89e 100644 (file)
@@ -301,7 +301,7 @@ static NTSTATUS make_lsa_object_sd(TALLOC_CTX *mem_ctx, struct security_descript
                                        struct dom_sid *sid, uint32_t sid_access)
 {
        struct dom_sid adm_sid;
-       struct security_ace ace[5];
+       struct security_ace ace[5] = {};
        size_t i = 0;
 
        struct security_acl *psa = NULL;