]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: swnode: defer probe on references to unregistered software nodes
authorBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tue, 7 Apr 2026 13:27:58 +0000 (15:27 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Thu, 9 Apr 2026 13:59:30 +0000 (15:59 +0200)
fwnode_property_get_reference_args() now returns -ENOTCONN when called
on a software node referencing another software node which has not yet
been registered as a firmware node. It makes sense to defer probe in this
situation as the node will most likely be registered later on and we'll
be able to resolve the reference eventually. Change the behavior of
swnode_find_gpio() to return -EPROBE_DEFER if the software node reference
resolution returns -ENOTCONN.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20260407-swnode-unreg-retcode-v4-2-1b2f0725eb9c@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpiolib-swnode.c

index 0d7f3f09a0b4bee0cf1bbdaa8b7b8ae4cd5de581..4374067f621ed782a7e1549f7b0b7e44eac04930 100644 (file)
@@ -93,6 +93,14 @@ struct gpio_desc *swnode_find_gpio(struct fwnode_handle *fwnode,
                ret = swnode_gpio_get_reference(fwnode, propname, idx, &args);
                if (ret == 0)
                        break;
+               if (ret == -ENOTCONN)
+                       /*
+                        * -ENOTCONN for a software node reference lookup means
+                        *  that a remote struct software_node exists but has
+                        *  not yet been registered as a firmware node. Defer
+                        *  until this happens.
+                        */
+                       return ERR_PTR(-EPROBE_DEFER);
        }
        if (ret) {
                pr_debug("%s: can't parse '%s' property of node '%pfwP[%d]'\n",