]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
net: mediatek: mt7988: free allocated MDIO bus on cleanup
authorChristian Marangi <ansuelsmth@gmail.com>
Sat, 20 Sep 2025 16:09:43 +0000 (18:09 +0200)
committerJerome Forissier <jerome.forissier@linaro.org>
Wed, 22 Oct 2025 09:16:10 +0000 (11:16 +0200)
Correctly free the MDIO Bus on calling cleanup function. While at it
also fix a copy-paste error and rename the cleanup function name to the
more specific name.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
drivers/net/mtk_eth/mt7988.c

index 06bbe049da3de9c98b2ca405e4d57af2c6fae917..b77660be55c2287d292c27e043607dd98ec872d0 100644 (file)
@@ -142,11 +142,13 @@ static int mt7988_setup(struct mtk_eth_switch_priv *swpriv)
        return mt7531_mdio_register(priv);
 }
 
-static int mt7531_cleanup(struct mtk_eth_switch_priv *swpriv)
+static int mt7988_cleanup(struct mtk_eth_switch_priv *swpriv)
 {
        struct mt753x_switch_priv *priv = (struct mt753x_switch_priv *)swpriv;
+       struct mii_dev *mdio_bus = priv->mdio_bus;
 
-       mdio_unregister(priv->mdio_bus);
+       mdio_unregister(mdio_bus);
+       mdio_free(mdio_bus);
 
        return 0;
 }
@@ -158,6 +160,6 @@ MTK_ETH_SWITCH(mt7988) = {
        .reset_wait_time = 50,
 
        .setup = mt7988_setup,
-       .cleanup = mt7531_cleanup,
+       .cleanup = mt7988_cleanup,
        .mac_control = mt7988_mac_control,
 };