]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/namespaces: remove unused utils.h include from listns_efault_test
authorChristian Brauner <brauner@kernel.org>
Tue, 31 Mar 2026 08:58:58 +0000 (10:58 +0200)
committerChristian Brauner <brauner@kernel.org>
Tue, 14 Apr 2026 07:31:18 +0000 (09:31 +0200)
Remove the inclusion of ../filesystems/utils.h from listns_efault_test.c.
The test doesn't use any symbols from that header. Including it alongside
../pidfd/pidfd.h causes a build failure because both headers define
wait_for_pid() with conflicting linkage:

  ../filesystems/utils.h:  extern int wait_for_pid(pid_t pid);
  ../pidfd/pidfd.h:        static inline int wait_for_pid(pid_t pid)

All symbols the test actually uses (create_child, read_nointr,
write_nointr, sys_pidfd_send_signal) come from pidfd.h.

Reported-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/all/acPV19IY3Gna6Ira@sirena.org.uk
Fixes: 07d7ad46dad4 ("selftests/namespaces: test for efault")
Signed-off-by: Christian Brauner <brauner@kernel.org>
tools/testing/selftests/namespaces/listns_efault_test.c

index c7ed4023d7a858e1ebd1935e15cb1a7471b9b8c2..b570746e917c117a2ccb19044334195bfe802dfa 100644 (file)
@@ -19,7 +19,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include "../kselftest_harness.h"
-#include "../filesystems/utils.h"
 #include "../pidfd/pidfd.h"
 #include "wrappers.h"