Don't block smbcontrol online/offline if !"winbind offline logons"

There's no point to block these, winbind will ignore them anyway.

Jerry, Jeremy, we definitely need a chance to trigger a reconnection attempt
after a DC has been rebooted. Right now winbind's reaction to a single rebooted
DC is to declare it offline. It will not try before a "winbind cache timeout"
timeout. If the admin sets this to an hour or longer for performance reasons,
we're screwed. Reboot your DC, no logon for an hour.

Volker

diff --git a/source/utils/smbcontrol.c b/source/utils/smbcontrol.c
index db2eefe1e2259f5b5b86f04babba30b41b5c92ab..6699763cd2d983624089f41d1eb567af9fa5b4cd 100644 (file)
--- a/source/utils/smbcontrol.c
+++ b/source/utils/smbcontrol.c
@@ -865,13 +865,6 @@ static bool do_winbind_online(struct messaging_context *msg_ctx,
                return False;
        }
 
-       if (!lp_winbind_offline_logon()) {
-               fprintf(stderr, "The parameter \"winbind offline logon\" must "
-                       "be set in the [global] section of smb.conf for this "
-                       "command to be allowed.\n");
-               return False;
-       }
-
        /* Remove the entry in the winbindd_cache tdb to tell a later
           starting winbindd that we're online. */
 
@@ -901,13 +894,6 @@ static bool do_winbind_offline(struct messaging_context *msg_ctx,
                return False;
        }
 
-       if (!lp_winbind_offline_logon()) {
-               fprintf(stderr, "The parameter \"winbind offline logon\" must "
-                       "be set in the [global] section of smb.conf for this "
-                       "command to be allowed.\n");
-               return False;
-       }
-
        /* Create an entry in the winbindd_cache tdb to tell a later
           starting winbindd that we're offline. We may actually create
           it here... */