]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: mptcp: join: mark 'flush re-add' as skipped if not supported
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Mon, 20 Oct 2025 20:53:27 +0000 (22:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:08:57 +0000 (14:08 +0100)
commit d68460bc31f9c8c6fc81fbb56ec952bec18409f1 upstream.

The call to 'continue_if' was missing: it properly marks a subtest as
'skipped' if the attached condition is not valid.

Without that, the test is wrongly marked as passed on older kernels.

Fixes: e06959e9eebd ("selftests: mptcp: join: test for flush/re-add endpoints")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-2-8207030cb0e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh

index 6b22b8c7374248b3bc777ff7f0efa9005f31ef16..737640f3b012ec2d6f14c7c2fb3efa9fc9019d35 100755 (executable)
@@ -3897,7 +3897,7 @@ endpoint_tests()
 
        # flush and re-add
        if reset_with_tcp_filter "flush re-add" ns2 10.0.3.2 REJECT OUTPUT &&
-          mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
+          continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
                pm_nl_set_limits $ns1 0 2
                pm_nl_set_limits $ns2 1 2
                # broadcast IP: no packet for this address will be received on ns1