arm64, tlbflush: don't TLBI broadcast if page reused in write fault

A multi-thread customer workload with large memory footprint uses
fork()/exec() to run some external programs every tens seconds.  When
running the workload on an arm64 server machine, it's observed that
quite some CPU cycles are spent in the TLB flushing functions.  While
running the workload on the x86_64 server machine, it's not.  This
causes the performance on arm64 to be much worse than that on x86_64.

During the workload running, after fork()/exec() write-protects all
pages in the parent process, memory writing in the parent process
will cause a write protection fault.  Then the page fault handler
will make the PTE/PDE writable if the page can be reused, which is
almost always true in the workload.  On arm64, to avoid the write
protection fault on other CPUs, the page fault handler flushes the TLB
globally with TLBI broadcast after changing the PTE/PDE.  However, this
isn't always necessary.  Firstly, it's safe to leave some stale
read-only TLB entries as long as they will be flushed finally.
Secondly, it's quite possible that the original read-only PTE/PDEs
aren't cached in remote TLB at all if the memory footprint is large.
In fact, on x86_64, the page fault handler doesn't flush the remote
TLB in this situation, which benefits the performance a lot.

To improve the performance on arm64, make the write protection fault
handler flush the TLB locally instead of globally via TLBI broadcast
after making the PTE/PDE writable.  If there are stale read-only TLB
entries in the remote CPUs, the page fault handler on these CPUs will
regard the page fault as spurious and flush the stale TLB entries.

To test the patchset, make the usemem.c from
vm-scalability (https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git).
support calling fork()/exec() periodically.  To mimic the behavior of
the customer workload, run usemem with 4 threads, access 100GB memory,
and call fork()/exec() every 40 seconds.  Test results show that with
the patchset the score of usemem improves ~40.6%.  The cycles% of TLB
flush functions reduces from ~50.5% to ~0.3% in perf profile.

Signed-off-by: Huang Ying <ying.huang@linux.alibaba.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Barry Song <baohua@kernel.org>
Acked-by: Zi Yan <ziy@nvidia.com>
Cc: Will Deacon <will@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Yang Shi <yang@os.amperecomputing.com>
Cc: Christoph Lameter (Ampere) <cl@gentwo.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Yin Fengwei <fengwei_yin@linux.alibaba.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Reviewed-by: David Hildenbrand (Red Hat) <david@kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
index aa89c2e67ebc84587d24e415b0fc1ddb6baccdc8..25b3c31edb6c8356cef7bfd555e0b1280ecc2656 100644 (file)
--- a/arch/arm64/include/asm/pgtable.h
+++ b/arch/arm64/include/asm/pgtable.h
@@ -130,12 +130,16 @@ static inline void arch_leave_lazy_mmu_mode(void)
 #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
 
 /*
- * Outside of a few very special situations (e.g. hibernation), we always
- * use broadcast TLB invalidation instructions, therefore a spurious page
- * fault on one CPU which has been handled concurrently by another CPU
- * does not need to perform additional invalidation.
+ * We use local TLB invalidation instruction when reusing page in
+ * write protection fault handler to avoid TLBI broadcast in the hot
+ * path.  This will cause spurious page faults if stale read-only TLB
+ * entries exist.
  */
-#define flush_tlb_fix_spurious_fault(vma, address, ptep) do { } while (0)
+#define flush_tlb_fix_spurious_fault(vma, address, ptep)       \
+       local_flush_tlb_page_nonotify(vma, address)
+
+#define flush_tlb_fix_spurious_fault_pmd(vma, address, pmdp)   \
+       local_flush_tlb_page_nonotify(vma, address)
 
 /*
  * ZERO_PAGE is a global shared page that is always zero: used

diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
index 18a5dc0c9a540f53cb2ed651d749012f38b9311f..682a01df71d2033d7c4806f95178f69506af49f8 100644 (file)
--- a/arch/arm64/include/asm/tlbflush.h
+++ b/arch/arm64/include/asm/tlbflush.h
@@ -249,6 +249,19 @@ static inline unsigned long get_trans_granule(void)
  *             cannot be easily determined, the value TLBI_TTL_UNKNOWN will
  *             perform a non-hinted invalidation.
  *
+ *     local_flush_tlb_page(vma, addr)
+ *             Local variant of flush_tlb_page().  Stale TLB entries may
+ *             remain in remote CPUs.
+ *
+ *     local_flush_tlb_page_nonotify(vma, addr)
+ *             Same as local_flush_tlb_page() except MMU notifier will not be
+ *             called.
+ *
+ *     local_flush_tlb_contpte(vma, addr)
+ *             Invalidate the virtual-address range
+ *             '[addr, addr+CONT_PTE_SIZE)' mapped with contpte on local CPU
+ *             for the user address space corresponding to 'vma->mm'.  Stale
+ *             TLB entries may remain in remote CPUs.
  *
  *     Finally, take a look at asm/tlb.h to see how tlb_flush() is implemented
  *     on top of these routines, since that is our interface to the mmu_gather
@@ -282,6 +295,33 @@ static inline void flush_tlb_mm(struct mm_struct *mm)
        mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);
 }
 
+static inline void __local_flush_tlb_page_nonotify_nosync(struct mm_struct *mm,
+                                                         unsigned long uaddr)
+{
+       unsigned long addr;
+
+       dsb(nshst);
+       addr = __TLBI_VADDR(uaddr, ASID(mm));
+       __tlbi(vale1, addr);
+       __tlbi_user(vale1, addr);
+}
+
+static inline void local_flush_tlb_page_nonotify(struct vm_area_struct *vma,
+                                                unsigned long uaddr)
+{
+       __local_flush_tlb_page_nonotify_nosync(vma->vm_mm, uaddr);
+       dsb(nsh);
+}
+
+static inline void local_flush_tlb_page(struct vm_area_struct *vma,
+                                       unsigned long uaddr)
+{
+       __local_flush_tlb_page_nonotify_nosync(vma->vm_mm, uaddr);
+       mmu_notifier_arch_invalidate_secondary_tlbs(vma->vm_mm, uaddr & PAGE_MASK,
+                                               (uaddr & PAGE_MASK) + PAGE_SIZE);
+       dsb(nsh);
+}
+
 static inline void __flush_tlb_page_nosync(struct mm_struct *mm,
                                           unsigned long uaddr)
 {
@@ -472,6 +512,22 @@ static inline void __flush_tlb_range(struct vm_area_struct *vma,
        dsb(ish);
 }
 
+static inline void local_flush_tlb_contpte(struct vm_area_struct *vma,
+                                          unsigned long addr)
+{
+       unsigned long asid;
+
+       addr = round_down(addr, CONT_PTE_SIZE);
+
+       dsb(nshst);
+       asid = ASID(vma->vm_mm);
+       __flush_tlb_range_op(vale1, addr, CONT_PTES, PAGE_SIZE, asid,
+                            3, true, lpa2_is_enabled());
+       mmu_notifier_arch_invalidate_secondary_tlbs(vma->vm_mm, addr,
+                                                   addr + CONT_PTE_SIZE);
+       dsb(nsh);
+}
+
 static inline void flush_tlb_range(struct vm_area_struct *vma,
                                   unsigned long start, unsigned long end)
 {

diff --git a/arch/arm64/mm/contpte.c b/arch/arm64/mm/contpte.c
index c0557945939ce7648fcd0455b758400d5bf633fb..589bcf878938840f24848b200cbbb7993ebe3021 100644 (file)
--- a/arch/arm64/mm/contpte.c
+++ b/arch/arm64/mm/contpte.c
@@ -622,8 +622,7 @@ int contpte_ptep_set_access_flags(struct vm_area_struct *vma,
                        __ptep_set_access_flags(vma, addr, ptep, entry, 0);
 
                if (dirty)
-                       __flush_tlb_range(vma, start_addr, addr,
-                                                       PAGE_SIZE, true, 3);
+                       local_flush_tlb_contpte(vma, start_addr);
        } else {
                __contpte_try_unfold(vma->vm_mm, addr, ptep, orig_pte);
                __ptep_set_access_flags(vma, addr, ptep, entry, dirty);

diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index d816ff44faff940ca1e306172fc6a025d81239d4..4ecdfa6bcdbb7e775e49874e585f902ba6355a8e 100644 (file)
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -233,9 +233,13 @@ int __ptep_set_access_flags(struct vm_area_struct *vma,
                pteval = cmpxchg_relaxed(&pte_val(*ptep), old_pteval, pteval);
        } while (pteval != old_pteval);
 
-       /* Invalidate a stale read-only entry */
+       /*
+        * Invalidate the local stale read-only entry.  Remote stale entries
+        * may still cause page faults and be invalidated via
+        * flush_tlb_fix_spurious_fault().
+        */
        if (dirty)
-               flush_tlb_page(vma, address);
+               local_flush_tlb_page(vma, address);
        return 1;
 }