bpo-40067: Improve error messages for multiple star expressions in assignments (GH...

Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>

diff --git a/Lib/test/test_unpack_ex.py b/Lib/test/test_unpack_ex.py
index 46f70c2b98c7099250226211c08cd889b4dbf43c..e333af78f1d2c1b442ffb4d9fe89ddc5093cc64b 100644 (file)
--- a/Lib/test/test_unpack_ex.py
+++ b/Lib/test/test_unpack_ex.py
@@ -308,12 +308,17 @@ Now some general starred expressions (all fail).
     >>> a, *b, c, *d, e = range(10) # doctest:+ELLIPSIS
     Traceback (most recent call last):
       ...
-    SyntaxError: two starred expressions in assignment
+    SyntaxError: multiple starred expressions in assignment
 
     >>> [*b, *c] = range(10) # doctest:+ELLIPSIS
     Traceback (most recent call last):
       ...
-    SyntaxError: two starred expressions in assignment
+    SyntaxError: multiple starred expressions in assignment
+
+    >>> a,*b,*c,*d = range(4) # doctest:+ELLIPSIS
+    Traceback (most recent call last):
+      ...
+    SyntaxError: multiple starred expressions in assignment
 
     >>> *a = range(10) # doctest:+ELLIPSIS
     Traceback (most recent call last):

diff --git a/Misc/ACKS b/Misc/ACKS
index 129db952d885f1e4cd9a2c40680c12f56f63ed1d..a4db5a547039dc82eacccc416cae25baafca3a33 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1236,6 +1236,7 @@ Jeffrey Ollie
 Adam Olsen
 Bryan Olson
 Grant Olson
+Furkan Onder
 Koray Oner
 Piet van Oostrum
 Tomas Oppelstrup

diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst b/Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst
new file mode 100644 (file)
index 0000000..2e1b20d
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067.0bFda2.rst
@@ -0,0 +1,2 @@
+Improve the error message for multiple star expressions in an assignment.\r
+Patch by Furkan Onder\r

diff --git a/Python/compile.c b/Python/compile.c
index 0b3926c436c6ac046a807e838a60387cb3944e17..01700e0e78cc9c78493bf13081f1246904342315 100644 (file)
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -3708,7 +3708,7 @@ assignment_helper(struct compiler *c, asdl_seq *elts)
         }
         else if (elt->kind == Starred_kind) {
             return compiler_error(c,
-                "two starred expressions in assignment");
+                "multiple starred expressions in assignment");
         }
     }
     if (!seen_star) {