]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4/dnsserver: delay return when trying to log (CID 1444976)
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 8 May 2019 02:37:06 +0000 (14:37 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 May 2019 22:39:27 +0000 (22:39 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source4/dns_server/dnsserver_common.c

index 04d50577eb658c77b58dfbedb189a0abc8c5eb88..5e687f6848e4a81f5bf43b58a1d3cab45483912b 100644 (file)
@@ -559,7 +559,7 @@ WERROR dns_common_wildcard_lookup(struct ldb_context *samdb,
 
        name = ldb_dn_get_rdn_val(dn);
        if (name == NULL) {
-               return DNS_ERR(NAME_ERROR);
+               werr = DNS_ERR(NAME_ERROR);
                goto exit;
        }
 
@@ -615,7 +615,6 @@ WERROR dns_common_wildcard_lookup(struct ldb_context *samdb,
        werr = dns_common_extract(samdb, el, mem_ctx, records, num_records);
        TALLOC_FREE(msg);
        if (!W_ERROR_IS_OK(werr)) {
-               return werr;
                goto exit;
        }