]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
batman-adv: Drop initialization of flexible ethtool_link_ksettings
authorSven Eckelmann <sven@narfation.org>
Sat, 20 Aug 2022 07:32:50 +0000 (09:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:47:27 +0000 (12:47 +0100)
[ Upstream commit 813e62a6fe7539fdf0d8e018d4f157b57bdaeedd ]

The commit 94dfc73e7cf4 ("treewide: uapi: Replace zero-length arrays with
flexible-array members") changed various structures from using 0-length
arrays to flexible arrays

  net/batman-adv/bat_v_elp.c: note: in included file:
  ./include/linux/ethtool.h:148:38: warning: nested flexible array
  net/batman-adv/bat_v_elp.c:128:9: warning: using sizeof on a flexible structure

In theory, this could be worked around by using {} as initializer for the
variable on the stack. But this variable doesn't has to be initialized at
all by the caller of __ethtool_get_link_ksettings - everything will be
initialized by the callee when no error occurs.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Stable-dep-of: 8c8ecc98f5c6 ("batman-adv: Drop unmanaged ELP metric worker")
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/batman-adv/bat_v_elp.c

index fb76b8861f098583848170c5f65a948dafa15630..81b9dfec7151a98dd1fe823d8afa4431955454d5 100644 (file)
@@ -141,7 +141,6 @@ static bool batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh,
        /* if not a wifi interface, check if this device provides data via
         * ethtool (e.g. an Ethernet adapter)
         */
-       memset(&link_settings, 0, sizeof(link_settings));
        rtnl_lock();
        ret = __ethtool_get_link_ksettings(hard_iface->net_dev, &link_settings);
        rtnl_unlock();