]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-136156: Remove tempfile test_link_tmpfile() (#136534)
authorVictor Stinner <vstinner@python.org>
Fri, 11 Jul 2025 14:45:31 +0000 (16:45 +0200)
committerGitHub <noreply@github.com>
Fri, 11 Jul 2025 14:45:31 +0000 (16:45 +0200)
It's not always possible to guarantee that the file was opened with
O_TMPFILE even if tempfile._O_TMPFILE_WORKS is true.

Lib/test/test_tempfile.py

index aeca62cf2564bcaf593c296a552efa1de5f3314d..52b13b98cbcce5cd14afbf8b14e8e51ac0f4d599 100644 (file)
@@ -1594,30 +1594,6 @@ if tempfile.NamedTemporaryFile is not tempfile.TemporaryFile:
             mock_close.assert_called()
             self.assertEqual(os.listdir(dir), [])
 
-        @os_helper.skip_unless_hardlink
-        @unittest.skipUnless(tempfile._O_TMPFILE_WORKS, 'need os.O_TMPFILE')
-        @unittest.skipUnless(os.path.exists('/proc/self/fd'),
-                             'need /proc/self/fd')
-        def test_link_tmpfile(self):
-            dir = tempfile.mkdtemp()
-            self.addCleanup(os_helper.rmtree, dir)
-            filename = os.path.join(dir, "link")
-
-            with tempfile.TemporaryFile('w', dir=dir) as tmp:
-                # the flag can become False on Linux <= 3.11
-                if not tempfile._O_TMPFILE_WORKS:
-                    self.skipTest("O_TMPFILE doesn't work")
-
-                tmp.write("hello")
-                tmp.flush()
-                fd = tmp.fileno()
-
-                os.link(f'/proc/self/fd/{fd}',
-                        filename,
-                        follow_symlinks=True)
-                with open(filename) as fp:
-                    self.assertEqual(fp.read(), "hello")
-
 
 # Helper for test_del_on_shutdown
 class NulledModules: