Try and fix use after free in logging buffer

diff --git a/src/lib/util/syserror.c b/src/lib/util/syserror.c
index a5fed0f5142e38c928a6d83e3ebaa61dd51c26b7..cb17c75f8ea903ca7b1b7f8feedaa9834e530750 100644 (file)
--- a/src/lib/util/syserror.c
+++ b/src/lib/util/syserror.c
@@ -34,9 +34,9 @@ fr_thread_local_setup(char *, fr_syserror_buffer)             /* macro */
  *     Explicitly cleanup the memory allocated to the error buffer,
  *     just in case valgrind complains about it.
  */
-static void _fr_logging_free(void *arg)
+static void _fr_logging_free(UNUSED void *arg)
 {
-       talloc_free(arg);
+       TALLOC_FREE(fr_syserror_buffer);        /* Set to NULL in case the buffer needs to be recreated */
 }
 
 /** POSIX-2008 errno macros