]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
dbus_message_demarshal: Fix calling _dbus_string_append_len without checking return...
authorRalf Habacker <ralf.habacker@freenet.de>
Wed, 6 May 2015 06:25:20 +0000 (08:25 +0200)
committerRalf Habacker <ralf.habacker@freenet.de>
Wed, 6 May 2015 10:10:18 +0000 (12:10 +0200)
Reported by Coverity: CID 54690: Unchecked return value (CHECKED_RETURN)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
dbus/dbus-message.c

index 3e74fc54e42c9091a917ebe957ad9af1e1e9341a..1f433712c6ebdede09e9418e7ba89a312b364210 100644 (file)
@@ -4796,7 +4796,10 @@ dbus_message_demarshal (const char *str,
     return NULL;
 
   _dbus_message_loader_get_buffer (loader, &buffer);
-  _dbus_string_append_len (buffer, str, len);
+
+  if (!_dbus_string_append_len (buffer, str, len))
+    goto fail_oom;
+
   _dbus_message_loader_return_buffer (loader, buffer);
 
   if (!_dbus_message_loader_queue_messages (loader))