Fix tls_connection_set_success_data() in TLS library wrappers

Some of the TLS library wrappers defined only an empty function for
tls_connection_set_success_data(). That could result in memory leaks in
TLS server cases, so update these to do the minimal thing and free the
provided buffer as unused.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>

diff --git a/src/crypto/tls_gnutls.c b/src/crypto/tls_gnutls.c
index daa01d9ed4f64a900102d36a834e72ff298289e9..e3f5b5a4227c05d8ab9fe0fd0ca02fb38484f6c0 100644 (file)
--- a/src/crypto/tls_gnutls.c
+++ b/src/crypto/tls_gnutls.c
@@ -1766,6 +1766,7 @@ int tls_get_library_version(char *buf, size_t buf_len)
 void tls_connection_set_success_data(struct tls_connection *conn,
                                     struct wpabuf *data)
 {
+       wpabuf_free(data);
 }
 
 

diff --git a/src/crypto/tls_internal.c b/src/crypto/tls_internal.c
index ef33b59f829e0c7cafed430a690b2df4a25739fe..f3e05ce3417ac630e71d2f068b348c252b3b7cfd 100644 (file)
--- a/src/crypto/tls_internal.c
+++ b/src/crypto/tls_internal.c
@@ -783,6 +783,7 @@ int tls_get_library_version(char *buf, size_t buf_len)
 void tls_connection_set_success_data(struct tls_connection *conn,
                                     struct wpabuf *data)
 {
+       wpabuf_free(data);
 }
 
 

diff --git a/src/crypto/tls_none.c b/src/crypto/tls_none.c
index 6d6fb0cafd31cd997ea3f261071a62d671b39821..87f45f8868528fa0ba51bd5c0df113ae85b2a6c0 100644 (file)
--- a/src/crypto/tls_none.c
+++ b/src/crypto/tls_none.c
@@ -212,6 +212,7 @@ int tls_get_library_version(char *buf, size_t buf_len)
 void tls_connection_set_success_data(struct tls_connection *conn,
                                     struct wpabuf *data)
 {
+       wpabuf_free(data);
 }