On Android, get_data_directory() should not use LOCALSTATEDIR

closes https://gitlab.torproject.org/tpo/core/tor/-/issues/40487

diff --git a/src/app/config/config.c b/src/app/config/config.c
index 8df5275cc6858f19b4725e796652f32e426bb6c3..3c3499696b6b869a87b0b9dff7718a974e798215 100644 (file)
--- a/src/app/config/config.c
+++ b/src/app/config/config.c
@@ -6883,6 +6883,15 @@ get_data_directory(const char *val)
   } else {
     return tor_strdup(get_windows_conf_root());
   }
+#elif defined(__ANDROID__)
+  /* Android apps can only use paths that are configured at runtime.
+   * /data/local/tmp is guaranteed to exist, but is only usable by the
+   * 'shell' and 'root' users, so this fallback is for debugging only. */
+  if (val) {
+    return tor_strdup(val);
+  } else {
+    return tor_strdup("/data/local/tmp");
+  }
 #else /* !defined(_WIN32) */
   const char *d = val;
   if (!d)