wifi: mac80211: remove tx_handlers_drop debugfs stats

Commit 906a5a8c7152 ("wifi: mac80211: add tx_handlers_drop statistics
to ethtool") added a tx_handlers_drop counter to ethtool stats.
During review [1], Johannes noted that the existing debugfs counter
is now redundant. Remove the debugfs stat to avoid duplication and
streamline statistics reporting.

Link: https://lore.kernel.org/linux-wireless/ce5f2bd899caa2de32f36ce554d9cada073979c0.camel@sipsolutions.net/
Signed-off-by: Sarika Sharma <quic_sarishar@quicinc.com>
Link: https://patch.msgid.link/20250918040846.4032734-1-quic_sarishar@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
index 82099f4cedbe06de266c2edaf0508b14d2abc977..d02f07368c5119837a64214543d272040b878cd2 100644 (file)
--- a/net/mac80211/debugfs.c
+++ b/net/mac80211/debugfs.c
@@ -715,7 +715,6 @@ void debugfs_hw_add(struct ieee80211_local *local)
        DEBUGFS_STATS_ADD(dot11ReceivedFragmentCount);
        DEBUGFS_STATS_ADD(dot11MulticastReceivedFrameCount);
        DEBUGFS_STATS_ADD(dot11TransmittedFrameCount);
-       DEBUGFS_STATS_ADD(tx_handlers_drop);
        DEBUGFS_STATS_ADD(tx_handlers_queued);
        DEBUGFS_STATS_ADD(tx_handlers_drop_wep);
        DEBUGFS_STATS_ADD(tx_handlers_drop_not_assoc);

diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 242cb109b232da23087d99be0e959b6ea7167257..414058bced1a482f8d6653f7f6c14438cbc89252 100644 (file)
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -1610,7 +1610,6 @@ struct ieee80211_local {
        u32 dot11TransmittedFrameCount;
 
        /* TX/RX handler statistics */
-       unsigned int tx_handlers_drop;
        unsigned int tx_handlers_queued;
        unsigned int tx_handlers_drop_wep;
        unsigned int tx_handlers_drop_not_assoc;

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index ba51198be94a8f5aec9a8b341afd104c5c69297d..e7b141c55f7a900964b15e72686544328d240bc3 100644 (file)
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1821,7 +1821,6 @@ static int invoke_tx_handlers_early(struct ieee80211_tx_data *tx)
  txh_done:
        if (unlikely(res == TX_DROP)) {
                tx->sdata->tx_handlers_drop++;
-               I802_DEBUG_INC(tx->local->tx_handlers_drop);
                if (tx->skb)
                        ieee80211_free_txskb(&tx->local->hw, tx->skb);
                else
@@ -1866,7 +1865,6 @@ static int invoke_tx_handlers_late(struct ieee80211_tx_data *tx)
  txh_done:
        if (unlikely(res == TX_DROP)) {
                tx->sdata->tx_handlers_drop++;
-               I802_DEBUG_INC(tx->local->tx_handlers_drop);
                if (tx->skb)
                        ieee80211_free_txskb(&tx->local->hw, tx->skb);
                else